[Ipopt] bug in computing average values in EquilibrationScaling

[victor.zverovich at gmail.com]

Hi Stefan.

Thanks for fixing this in the repository. Here's another trivial patch for
a minor bug in #ifdef (using "not" instead of "!").

Cheers,
Victor




On Mon, Apr 28, 2014 at 3:07 PM, Stefan Vigerske
<stefan at math.hu-berlin.de>wrote:

> Hi,
>
> thanks a lot.
> I've fixed this in trunk and stable/3.11, it will be in the next release.
>
> Stefan
>
>
> On 04/28/2014 10:49 PM, victor.zverovich at gmail.com wrote:
>
>> Hi,
>>
>> There is a bug in computing avrg_values in Ipopt at
>> https://projects.coin-or.org/Ipopt/browser/trunk/Ipopt/src/Algorithm/
>> IpEquilibrationScaling.cpp#L135and
>> two similar cases below. Instead of
>>
>>    avrg_values[i] =+ fabs(val_buffer[i]);
>>
>> there should be
>>
>>    avrg_values[i] += fabs(val_buffer[i]);
>>
>> Otherwise the value is simply overwritten every time.
>>
>> The attached patch fixes the bug.
>>
>> Best regards,
>> Victor
>>
>>
>>
>> _______________________________________________
>> Ipopt mailing list
>> Ipopt at list.coin-or.org
>> http://list.coin-or.org/mailman/listinfo/ipopt
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.coin-or.org/pipermail/ipopt/attachments/20140502/abb34a71/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-ifdef.patch
Type: text/x-patch
Size: 1242 bytes
Desc: not available
URL: <http://list.coin-or.org/pipermail/ipopt/attachments/20140502/abb34a71/attachment.bin>