[Coin-lpsolver] Re: Suggestions for OsiCpx

[kevin.c.furman at exxonmobil.com]

Brady,

I understand the need for review.  I do think some formalized online
submission system for simple bug reporting and also for code patch
development is going to be eventually necessary.

I think that it would be best in the long term for all COIN-OR projects to
adopt an explicit and common code review policy, common code style
guidelines (one for each language?), and common code documentation
guidelines.

Obviously this can't all be instituted overnight, but it should be in the
mid-to-long term vision.

Regards,

Kevin Furman



                                                                                                                                        
                      Brady Hunsaker                                                                                                    
                      <hunsaker at engr.pitt.e          To:      kevin.c.furman at exxonmobil.com                                             
                      du>                            cc:      coin-lpsolver at list.coin-or.org                                            
                                                     Subject: Re: [Coin-lpsolver] Re: Suggestions for OsiCpx                            
                                                                                                                                        
                      05/04/05 02:37 PM                                                                                                 
                                                                                                                                        
                                                                                                                                        



kevin.c.furman at exxonmobil.com wrote:
> Ted,
>
> Since COIN is open source, shouldn't Jean-Sebastian simply be able to
> upload his revised version of the code with his updates onto the server?
>

No.  Each project has one or more people who are authorized to actually
commit changes to the project.  This provides a quality-control check
for submitted code and prevents coders with differences of opinion from
constantly writing over each others' changes.  It also provides an
important legal check, so that we can be more confident that
contributions are made legally.

It also introduces some administrative overhead, unfortunately.

Note that if a user gains respect over time by submitting high-quality
contributions and demonstrating concern for a particular project, then
at some point they may be given authorization to commit changes themselves.

The fact that the code is open-source means that anyone could take the
code, make any changes they like, and redistribute it on their own (as
long as they follow the terms of the license).  In this sense there is
no user lock-in;  if COIN-OR becomes so bad at administering the
projects and responding to users' needs that someone feels they would be
better off doing it themselves, then they are free to copy all the code
and administer their own "forks" of the projects.

We are working to make COIN-OR faster at responding to submissions; if
you have specific suggestions for improving, we'd be happy to hear them
(I say "we", because I am a member of the COIN-OR Strategic Leadership
Board).  You could email me directly or put the suggestion on
coin-discuss if you prefer a public forum.

Brady

--
Brady Hunsaker
Assistant Professor
Industrial Engineering
University of Pittsburgh
http://www.engr.pitt.edu/hunsaker/