[Coin-lpsolver] Error in ClpNonLinearCost::refreshCosts

John J Forrest jjforre at us.ibm.com
Mon Jul 31 03:01:52 EDT 2006


David,

Thanks for pointing out the error.  Luckily on a quick grep I think
refreshCosts is not used!  I have fixed in development branch.

John Forrest


                                                                           
             <librik at panix.com                                             
             >                                                             
             Sent by:                                                   To 
             coin-lpsolver-bou         coin-lpsolver at list.coin-or.org      
             nces at list.coin-or                                          cc 
             .org                                                          
                                                                   Subject 
                                       [Coin-lpsolver] Error in            
             07/31/06 12:09 AM         ClpNonLinearCost::refreshCosts      
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




There's an error in line 6 of the method ClpNonLinearCost::refreshCosts
(in Clp/src/ClpNonLinearCost.cpp)

The line:
             if ((method_&1!=0)) {
is certainly not what you want.

Bitwise & has an unexpectedly low precedence, even lower than !=.

Parenthesize the line as follows:
             if ((method_&1)!=0) {
and the semantics will be what you expect.

- David Librik
librik at panix.com
_______________________________________________
Coin-lpsolver mailing list
Coin-lpsolver at list.coin-or.org
http://list.coin-or.org/mailman/listinfo/coin-lpsolver





More information about the Clp mailing list