[Cbc] unnecessary complicated code in CbcOrClpParam.cpp?

[Tobias Stengel]

Forrest,

thanks - I saw those lines by chance while debugging a problem with my code. I totally agree that it was a very minor issue. Such things can be found in every large codebase. I am not looking for such stuff and don't care why and who created them, but silently fixing them whenever one appears is the only way to get rid of them. I just don't know the CBC way of doing it - any information would be welcomed!

Tobias

Von: Cbc [mailto:cbc-bounces at coin-or.org] Im Auftrag von John Forrest
Gesendet: Mittwoch, 17. August 2016 10:33
An: cbc at list.coin-or.org
Betreff: Re: [Cbc] unnecessary complicated code in CbcOrClpParam.cpp?

Tobias,

I am sure you can come up with worse examples of my bad coding - fixed in stable and trunk.

John Forrest

On 17/08/16 09:04, Tobias Stengel wrote:
Hello,

I found

field = argv[CbcOrClpRead_mode++];
// -- means import from stdin
field = "-";

in CbcOrClpParam.cpp, line 1411-1413. As far as I can see,

++CbcOrClpRead_mode;
// -- means import from stdin
field = "-";

would do the same. As nobody has submitted a pull request on github: what ist the prefered way for contributing such small changes? Posting on the mailing list and waiting for Forrest looks complicated.

Tobias





_______________________________________________

Cbc mailing list

Cbc at list.coin-or.org<mailto:Cbc at list.coin-or.org>

http://list.coin-or.org/mailman/listinfo/cbc


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.coin-or.org/pipermail/cbc/attachments/20160817/6afa325a/attachment-0001.html>