[BuildTools] [Coin-tlc] Recent changes

[Ted Ralphs]

It seems like the easiest solution to the DESTDIR problem is just to append
the directory to the PKG_CONFIG_PATH in Makefile.am, rather than replacing
it, as is done in the patch, like so.

if COIN_HAS_PKGCONFIG
        PKG_CONFIG_PATH="@COIN_PKG_CONFIG_PATH@":$(DESTDIR)$(pkgconfiglibdir)
\
        "$(PKG_CONFIG)" --libs coinutils >
$(addlibsdir)/coinutils_addlibs.txt
else
...
endif

This should not break anything that currently works and I think will fix
the problem (i.e., patches should no longer be required), but it occurs to
me that it may not be the most elegant solution. Any thoughts?

Note that this actually does not require any changes to the build system
itself. Since it seems DESTDIR is specified as an argument to make, not to
configure, this doesn't seem to be an issue with coin.m4 and won't require
any new releases of BuildTools. I guess we could have fixed it a long time
ago :). Unfortunately, we do have to modify Makefile.am for every project
individually,

Cheers,

Ted

On Tue, Jan 20, 2015 at 4:42 PM, Ted Ralphs <ted at lehigh.edu> wrote:

> I tend to agree with Stefan about changing the default behavior of
> --with-pic. If we can get ASL fixed up so it pays attention to this
> argument, that should be enough for me.
>
> I will try to implement something to address the patches on Debian and
> Fedora in light of Stefan's comments, although the situations in which
> things might break are not ones we ordinarily encounter in the typical
> build process so testing will take some creativity.
>
> Cheers,
>
> Ted
>
> On Tue, Jan 20, 2015 at 12:48 PM, Miles Lubin <miles.lubin at gmail.com>
> wrote:
>
>> Hi Tony,
>>
>> Yes, the debian patches are identical. This is the only issue that we
>> currently have to patch, so I'd be quite happy to not need any patches at
>> all.
>>
>> Miles
>>
>> On Mon, Jan 19, 2015 at 1:47 AM, Tony Kelman <kelman at berkeley.edu> wrote:
>>
>>>   Ted et al,
>>>
>>> Looks like I just missed the boat on the .0 releases of the new stables.
>>> I wish I had remembered slightly earlier, but this would have been a good
>>> time to try to resolve
>>> https://projects.coin-or.org/BuildTools/ticket/104. Debian and Fedora
>>> have to carry local patches to make installing with DESTDIR work, the
>>> patches themselves are pretty simple. Here are Fedora’s, hopefully Miles
>>> can tell us whether or not Debian’s look exactly the same.
>>>
>>>
>>> http://pkgs.fedoraproject.org/cgit/coin-or-CoinUtils.git/tree/coin-or-CoinUtils-pkgconfig.patch
>>>
>>> http://pkgs.fedoraproject.org/cgit/coin-or-Osi.git/tree/coin-or-Osi-pkgconfig.patch
>>>
>>> http://pkgs.fedoraproject.org/cgit/coin-or-Clp.git/tree/coin-or-Clp-pkgconfig.patch
>>>
>>> http://pkgs.fedoraproject.org/cgit/coin-or-Cgl.git/tree/coin-or-Cgl-pkgconfig.patch
>>>
>>> http://pkgs.fedoraproject.org/cgit/coin-or-Cbc.git/tree/coin-or-Cbc-pkgconfig.patch
>>>
>>> http://pkgs.fedoraproject.org/cgit/coin-or-Ipopt.git/tree/coin-or-Ipopt-pkgconfig.patch
>>> I believe Couenne and OS need the same but they aren’t packaged in
>>> Fedora yet.
>>>
>>> Obviously we’d need to apply the same changes to the corresponding
>>> Makefile.am files as well.
>>>
>>> -Tony
>>>
>>>
>>>  *From:* Ted Ralphs <ted at lehigh.edu>
>>> *Sent:* Friday, January 16, 2015 8:17 AM
>>> *To:* Buildtools <buildtools at list.coin-or.org>
>>> *Cc:* coin-tlc <coin-tlc at list.coin-or.org>
>>> *Subject:* [Coin-tlc] Recent changes
>>>
>>>  Hi all,
>>>
>>> I recently made several changes to the build tools that I wanted to make
>>> you aware of.
>>>
>>> 1. I made release 0.7.18 that changes from the use of the vecLib
>>> framework to the use of the Accelerate framework on OS X. The vecLib
>>> framework is no longer included in OS X as of 10.9.
>>>
>>> 2. I made a new stable version 0.8 and changed dependency linking to be
>>> the default in all configurations except with the Visual Studio compilers.
>>>
>>> I am planning to make a new release 0.8.0 shortly and then will begin
>>> switching trunks of all projects that use the BuildTools to point to
>>> stable/0.8. Is there anything else that should be changed in stable/0.8
>>> before we make the first release?
>>>
>>> After switching trunks of all projects, I will begin making new stables
>>> and releases for all projects. This will eventually be followed by a new
>>> stable version 1.8 of CoinAll.
>>>
>>> Cheers,
>>>
>>> Ted
>>> --
>>>  Dr. Ted Ralphs
>>> Professor, Lehigh University
>>> (610) 628-1280
>>> ted 'at' lehigh 'dot' edu
>>> coral.ie.lehigh.edu/~ted
>>>
>>> ------------------------------
>>> _______________________________________________
>>> Coin-tlc mailing list
>>> Coin-tlc at list.coin-or.org
>>> http://list.coin-or.org/mailman/listinfo/coin-tlc
>>>
>>>
>>> _______________________________________________
>>> Coin-tlc mailing list
>>> Coin-tlc at list.coin-or.org
>>> http://list.coin-or.org/mailman/listinfo/coin-tlc
>>>
>>>
>>
>
>
> --
> Dr. Ted Ralphs
> Professor, Lehigh University
> (610) 628-1280
> ted 'at' lehigh 'dot' edu
> coral.ie.lehigh.edu/~ted
>



-- 
Dr. Ted Ralphs
Professor, Lehigh University
(610) 628-1280
ted 'at' lehigh 'dot' edu
coral.ie.lehigh.edu/~ted
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.coin-or.org/pipermail/buildtools/attachments/20150123/3e295b78/attachment.html>