From lou at cs.sfu.ca Fri Mar 7 12:29:29 2008 From: lou at cs.sfu.ca (Lou Hafer) Date: Fri, 7 Mar 2008 09:29:29 -0800 (PST) Subject: [BuildTools] Why are ProjConfig.h files not `include once'? Message-ID: <200803071729.m27HTTm3021267@cs.sfu.ca> Folks, Not exactly a BuildTools problem, but this list should reach the appropriate people. I was playing with the Osi unit test today and (to make a long story short) tracked a bit of strangeness to the fact that the various ProjConfig.h files do not guard against multiple inclusion. To use Osi as an example, there's the usual #ifndef __OSICONFIG_H__ ... #endif structure, but __OSICONFIG_H__ is never defined. I can't think of any good reason for the omission, but it seems universal. Every ProjConfig.h file I looked at has the same omission. Does anyone recall if there's a reason for this? I thought I'd better inquire before I change anything. Lou From andreasw at watson.ibm.com Fri Mar 7 13:34:21 2008 From: andreasw at watson.ibm.com (Andreas Waechter) Date: Fri, 7 Mar 2008 13:34:21 -0500 (EST) Subject: [BuildTools] Why are ProjConfig.h files not `include once'? In-Reply-To: <200803071729.m27HTTm3021267@cs.sfu.ca> References: <200803071729.m27HTTm3021267@cs.sfu.ca> Message-ID: Hi Lou, Yes, I guess that was my mistake... The define should be there. Good catch! Cheers Andreas On Fri, 7 Mar 2008, Lou Hafer wrote: > Folks, > > Not exactly a BuildTools problem, but this list should reach the > appropriate people. > > I was playing with the Osi unit test today and (to make a long story > short) tracked a bit of strangeness to the fact that the various ProjConfig.h > files do not guard against multiple inclusion. To use Osi as an example, > there's the usual > > #ifndef __OSICONFIG_H__ > ... > #endif > > structure, but __OSICONFIG_H__ is never defined. I can't think of any good > reason for the omission, but it seems universal. Every ProjConfig.h file I > looked at has the same omission. > > Does anyone recall if there's a reason for this? I thought I'd better > inquire before I change anything. > > Lou > > > _______________________________________________ > BuildTools mailing list > BuildTools at list.coin-or.org > http://list.coin-or.org/mailman/listinfo/buildtools >